-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongo recipe should install pymongo #81
Conversation
Hi @dwradcliffe, Thanks for the contribution! One open question: Is the python-pymongo package name valid on both CentOS/Ubuntu? If not, can you add a platform-specific block, like this one? |
Yep, I saw the same package name on both platforms. |
I ran a search for Ubuntu, found it only on certain (recent?) versions: Whereas on CentOS, it's not in the core, and requires EPEL, where the name differs: Unless you have a different resource? |
Ok, looks like the package only exists for Ubuntu 12.04 and later. Should I make the package conditional based on the Ubuntu version? The yum EPEL package is under both names (http://dl.fedoraproject.org/pub/epel/6/x86_64/repoview/python-pymongo.html). Just pushed a fix for that. |
@dwradcliffe I've been thinking about this one, and I think I'm going to prefer using a non-distro package, rather an
Would you consider refactoring for a python package installation? Thanks! |
@miketheman Good points, especially the 3rd one. Would |
Seems to work for me on Ubuntu and CentOS. Latest code push includes a test-kitchen suite. |
Thanks @dwradcliffe ! Merged in, added some testing. Will go in next release! |
Awesome! |
This also includes basic node attribute example.